Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve Examples #420

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

cseewald
Copy link
Contributor

I am currently incorporating DB-Scheduler into a project I am working on (10000 onetimetasks processed per hour in an Oracle database). Thanks for your awesome work!!

I decided to contribute something very modest back.

Changes

  • Removed ExampleHelpers.java: method sleep was unused, method registerShutdownHook is replaced by registerShutdownHook in SchedulerBuilder
  • Add missing main method in RecurringTaskMain.java

Reminders

  • [-] Added/ran automated tests
  • [-] Update README and/or examples
  • Ran mvn spotless:apply

cc @kagkarlsson

* Remove ExampleHelpers.java: method sleep was unused, method registerShutdownHook is replaced by registerShutdownHook in SchedulerBuilder
* Add missing main method in RecurringTaskMain.java
@kagkarlsson
Copy link
Owner

Excellent! Thank you for contributing! 🙏

@kagkarlsson kagkarlsson changed the title Improve Examples doc: Improve Examples Sep 14, 2023
@kagkarlsson
Copy link
Owner

Btw this PR might be of interest to you as well. It will introduce explicit LIMIT in the fetch-query for all databases.

#371

@kagkarlsson kagkarlsson changed the title doc: Improve Examples docs: Improve Examples Sep 15, 2023
Copy link
Owner

@kagkarlsson kagkarlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning up the examples! 🙏

@kagkarlsson kagkarlsson merged commit e098bd2 into kagkarlsson:master Sep 16, 2023
@cseewald
Copy link
Contributor Author

Btw this PR might be of interest to you as well. It will introduce explicit LIMIT in the fetch-query for all databases.

#371

Yes, I will probably update when it it is part of a release: To make sure the existing db-scheduler version actually works with many 1000 rows in the task table I did a test with huge task data and many 1000 rows within a highly memory constraint JVM. The java.sql.Statement#setMaxRows already seems to do a good enough job to only fetch the limited number of rows from the db. But I guess the explicit LIMIT clause helps with query performance.

@kagkarlsson kagkarlsson added the released Issue has been released label Dec 6, 2023
@kagkarlsson
Copy link
Owner

🎉 This issue has been resolved in v13.0.0 (Release Notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants