Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief
There are a total of 3 changes done in this PR
Refactored complex conditional statement in oneExecutionDone method inside:
com.github.kagkarlsson.scheduler > DueExecutionsBatch > oneExecutionDone
Long method named updateHeartbeats() has been refactored using extract method technique.
com.github.kagkarlsson.scheduler > Scheduler > updateHeartbeats
Renamed the variable name so that it better reflects the method's intent or variable's purpose clearly.
com.github.kagkarlsson.scheduler > Scheduler > delegate
Fixes
It does not necessarily fix any issues, this pull requests solves a few implementation smells in the code.
Reminders
mvn spotless:apply
cc @kagkarlsson