Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring smells #564

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Refactoring smells #564

wants to merge 8 commits into from

Conversation

tapanxd
Copy link

@tapanxd tapanxd commented Nov 28, 2024

Brief

There are a total of 3 changes done in this PR

  • Refactored complex conditional statement in oneExecutionDone method inside:
    com.github.kagkarlsson.scheduler > DueExecutionsBatch > oneExecutionDone

  • Long method named updateHeartbeats() has been refactored using extract method technique.
    com.github.kagkarlsson.scheduler > Scheduler > updateHeartbeats

  • Renamed the variable name so that it better reflects the method's intent or variable's purpose clearly.
    com.github.kagkarlsson.scheduler > Scheduler > delegate

Fixes

It does not necessarily fix any issues, this pull requests solves a few implementation smells in the code.

Reminders

  • Added/ran automated tests
  • Update README and/or examples
  • Ran mvn spotless:apply

cc @kagkarlsson

@tapanxd
Copy link
Author

tapanxd commented Nov 28, 2024

Hi @kagkarlsson, can you provide a feedback on this PR?

@tapanxd tapanxd changed the title Refactoring implementation smells Refactoring smells Nov 30, 2024
@kagkarlsson
Copy link
Owner

Appreciate the effort. Not exactly sure when I will have the bandwidth to have a look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants