Spring boot support #63

evenh · 2019-07-23T10:39:17Z

This PR addresses #55 and provides an initial implementation for Spring Boot integration.

This enables creation of different modules more easily

This needs to be verified

This should be named ${project}-spring-boot-starter by convention

See https://editorconfig.org for more information

kagkarlsson · 2019-07-23T18:46:11Z

Awesome, thanks! Will have a look! :)

evenh · 2019-07-23T18:49:22Z

Please feel free to be frank in the review. I know Spring Boot better than the DB scheduler :-)

…

23. jul. 2019 kl. 20:46 skrev Gustav Karlsson ***@***.***>: Awesome, thanks! Will have a look! :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

kagkarlsson

Looks good, though probably will need a second scan of things :)

Would be neat with some short example Main showing a minimal example, ala for example https://github.com/kagkarlsson/db-scheduler/blob/master/src/test/java/com/github/kagkarlsson/scheduler/example/CronMain.java

.editorconfig

kagkarlsson · 2019-07-23T18:56:18Z

NOTICE

+  Spring Expression Language (SpEL) under Apache License, Version 2.0
+  Spring JDBC under Apache License, Version 2.0
+  Spring TestContext Framework under Apache License, Version 2.0
+  Spring Transaction under Apache License, Version 2.0


Will check this later..

...n/java/com/github/kagkarlsson/scheduler/boot/autoconfigure/DbSchedulerAutoConfiguration.java

...tarter/src/main/java/com/github/kagkarlsson/scheduler/boot/config/DbSchedulerProperties.java

...n/java/com/github/kagkarlsson/scheduler/boot/autoconfigure/DbSchedulerAutoConfiguration.java

kagkarlsson · 2019-07-23T20:04:31Z

Hmm, I think we are missing the startTasks(...) aspect for kicking off initial execution for recurring tasks, see https://github.com/kagkarlsson/db-scheduler/blob/master/src/test/java/com/github/kagkarlsson/scheduler/example/TasksMain.java#L41

Tasks that also implement OnStartup should be added to the builder via startTasks(...) method

evenh · 2019-07-24T22:38:36Z

I've implemented the startTasks invocation in the builder, where I've filtered out tasks which do and do not implement OnStartup.

As for the examples, should they be separate "real" Spring Boot projects? I was thinking something like (Maven hierarchy):

| db-scheduler
| db-scheduler-boot-starter
| examples
|  --> spring-boot-example
|  --> vanilla-java-example?
|  --> other-example?

The benefit of this approach is breakage of the examples if the library/integrations change :-)

This adds a new getter in Scheduler

cash1981 · 2019-07-29T08:55:18Z

...n/java/com/github/kagkarlsson/scheduler/boot/autoconfigure/DbSchedulerAutoConfiguration.java

+        log.info("Creating DB Scheduler using tasks from Spring context: {}", configuredTasks);
+
+        if (existingDataSource instanceof TransactionAwareDataSourceProxy) {
+            log.info("Using a transaction aware DataSource");


Is this really necessary information to give? I guess the else block info makes more sense than this?

Probably not worthy of an info but a debug might be handy?

cash1981 · 2019-07-29T10:23:08Z

...n/java/com/github/kagkarlsson/scheduler/boot/autoconfigure/DbSchedulerAutoConfiguration.java

+        if (existingDataSource instanceof TransactionAwareDataSourceProxy) {
+            log.info("Using a transaction aware DataSource");
+        } else {
+            log.info("The configured DataSource is not transaction aware: '{}'. Operations such as schedule, reschedule and cancel will have effect regardless of spanning transactions.", existingDataSource);


This log statement is a bit confusing. What is the purpose of this?

Are there cases where a Spring-user might send in a datasource is not transaction-aware by mistake?

@cash1981: I thought that information whether one uses an instance of TransactionAwareDataSourceProxy would be useful information, see the docs.

However, I can't seem to get Spring Boot's configuration to provide me with a TransactionAwareDataSourceProxy out of the box (using JPA or JDBC starter, @EnableTransactionManagement on/off and using a local PostgreSQL db).

cash1981 · 2019-07-29T11:23:28Z

Perhaps also update the documentation on how to add db-scheduler using Spring and this PR?

evenh · 2019-07-29T19:07:08Z

Absolutely @cash1981! As pointed out in this comment, we should consider adding some examples and link to those as well.

kagkarlsson · 2019-07-31T19:39:14Z

@evenh Yeah for spring-boot I think it makes sense to have an examples-directory with a full project that is part of the build. We can link to it from the documentation. If necessary, code can be copied to the markdown-doc. Maybe a separate markdown-page for usage in spring-boot which we link to.

If you could create an example project @evenh , I can update the doc :)

evenh · 2019-07-31T23:03:57Z

Fixed @kagkarlsson :)

…-page.

kagkarlsson · 2019-08-02T10:18:35Z

Ran the example and shutdown seem to be working as exepected @cash1981

kagkarlsson · 2019-08-06T05:54:22Z

I think we need to wrap the datasource in a TransactionAwareDataSourceProxy if it is not already

kagkarlsson · 2019-08-06T16:11:45Z

Enabled maven-dependency-plugin:

[WARNING] Used undeclared dependencies found:
[WARNING]    org.springframework.boot:spring-boot-test:jar:2.1.6.RELEASE:test
[WARNING]    org.assertj:assertj-core:jar:3.11.1:test
[WARNING]    org.springframework.boot:spring-boot-autoconfigure:jar:2.1.6.RELEASE:compile
[WARNING]    org.springframework.boot:spring-boot-actuator:jar:2.1.6.RELEASE:compile
[WARNING]    org.springframework.boot:spring-boot:jar:2.1.6.RELEASE:compile
[WARNING]    junit:junit:jar:4.12:test
[WARNING]    org.slf4j:slf4j-api:jar:1.7.26:compile
[WARNING]    org.springframework:spring-context:jar:5.1.8.RELEASE:compile
[WARNING] Unused declared dependencies found:
[WARNING]    org.springframework.boot:spring-boot-configuration-processor:jar:2.1.6.RELEASE:compile
[WARNING]    org.springframework.boot:spring-boot-starter:jar:2.1.6.RELEASE:compile
[WARNING]    org.springframework.boot:spring-boot-autoconfigure-processor:jar:2.1.6.RELEASE:compile```

Will see if I can fix a couple..

kagkarlsson · 2019-08-07T19:38:45Z

Merging this PR. Further improvements can be suggested as separate issues.

Spring boot support

evenh added 11 commits July 5, 2019 22:56

Move db-scheduler into a separate core module

92c5c0e

This enables creation of different modules more easily

Fix missing test imports

fad4dfa

Move NOTICE generation to the root

3279e59

This needs to be verified

Empty new module for Spring Boot

e1d8ff4

This should be named ${project}-spring-boot-starter by convention

Port configuration for creating Scheduler bean

2904b21

Add editorconfig for consistent style

2b1097a

See https://editorconfig.org for more information

Use managed Spring Boot versions

b90c4af

Initial auto configuration tests

67772c5

Some more test cases

0fffc82

Move dependencies to the actual db-scheduler

5ad69ce

Log upon startup whether the DataSource is transaction aware

9c0b7b7

kagkarlsson reviewed Jul 23, 2019

View reviewed changes

evenh added 4 commits July 24, 2019 14:59

config: immediateExecution -> immediateExecutionEnabled

5f1181a

Set Ubuntu Trusty as Travis OS

3bef4c0

Invoke startTasks in the builder

875f1e7

Adjust transaction aware notice

c94a269

evenh added 2 commits July 26, 2019 10:22

Add automatic health check

c6f59cf

This adds a new getter in Scheduler

Add a property for disabling the scheduler config

b4722c4

cash1981 reviewed Jul 29, 2019

View reviewed changes

Add Spring Boot example

8057d0f

Changing DB Scheduler references to db-scheduler. Moving doc to front…

eabe736

…-page.

evenh added 2 commits August 6, 2019 12:35

Fix Maven deprecation

c84632e

Wrap DataSource in TransactionAwareDataSourceProxy if needed

bae96f3

kagkarlsson added 3 commits August 6, 2019 18:12

Enable maven-dependency-plugin for boot-starter

4d7a884

Fix some dependencies

14c32c0

Fix some more dependencies

eeb005d

kagkarlsson merged commit ca30dd7 into kagkarlsson:master Aug 7, 2019

kagkarlsson mentioned this pull request Aug 7, 2019

Spring / SpringBoot integration #55

Closed

evenh pushed a commit to evenh/db-scheduler that referenced this pull request Oct 1, 2020

Merge pull request kagkarlsson#63 from evenh/spring-boot-support

2d2a592

Spring boot support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spring boot support #63

Spring boot support #63

evenh commented Jul 23, 2019

kagkarlsson commented Jul 23, 2019

evenh commented Jul 23, 2019 via email

kagkarlsson left a comment

kagkarlsson Jul 23, 2019

kagkarlsson commented Jul 23, 2019

evenh commented Jul 24, 2019

cash1981 Jul 29, 2019

evenh Jul 29, 2019

cash1981 Jul 29, 2019

kagkarlsson Jul 29, 2019

evenh Jul 29, 2019

cash1981 commented Jul 29, 2019

evenh commented Jul 29, 2019

kagkarlsson commented Jul 31, 2019

evenh commented Jul 31, 2019

kagkarlsson commented Aug 2, 2019

kagkarlsson commented Aug 6, 2019

kagkarlsson commented Aug 6, 2019

kagkarlsson commented Aug 7, 2019

Spring boot support #63

Spring boot support #63

Conversation

evenh commented Jul 23, 2019

kagkarlsson commented Jul 23, 2019

evenh commented Jul 23, 2019 via email

kagkarlsson left a comment

Choose a reason for hiding this comment

kagkarlsson Jul 23, 2019

Choose a reason for hiding this comment

kagkarlsson commented Jul 23, 2019

evenh commented Jul 24, 2019

cash1981 Jul 29, 2019

Choose a reason for hiding this comment

evenh Jul 29, 2019

Choose a reason for hiding this comment

cash1981 Jul 29, 2019

Choose a reason for hiding this comment

kagkarlsson Jul 29, 2019

Choose a reason for hiding this comment

evenh Jul 29, 2019

Choose a reason for hiding this comment

cash1981 commented Jul 29, 2019

evenh commented Jul 29, 2019

kagkarlsson commented Jul 31, 2019

evenh commented Jul 31, 2019

kagkarlsson commented Aug 2, 2019

kagkarlsson commented Aug 6, 2019

kagkarlsson commented Aug 6, 2019

kagkarlsson commented Aug 7, 2019