Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #16

Merged
merged 2 commits into from
May 27, 2022
Merged

Update Dockerfile #16

merged 2 commits into from
May 27, 2022

Conversation

olipayne
Copy link
Contributor

added bottle to the pip installed packages, so we can run ./server.py easily too

added bottle to the pip installed packages, so we can run ./server.py easily too
@kahst
Copy link
Owner

kahst commented Apr 20, 2022

You're right, that's a good addition. Should we change the entry point too to be more generic so that we can launch scripts other than the analyzer?

@olipayne
Copy link
Contributor Author

I guess some people will want to run the docker image with analyze.py and some with server.py, so there's no real right way.

To lower the entry threshold for interested people, you could set up github actions to build a new image on every commit to main branch. I've done something similar here

@kahst
Copy link
Owner

kahst commented Apr 21, 2022

There's another PR (#19) coming in, which has docker files for server and client. What do you think, should we go with separate files and merge #19?

@olipayne
Copy link
Contributor Author

Just had a look at #19, it seems to go quite against Dockerfile best practises (non-standard filename, not installing pip packages in 1 line for caching improvements etc.

I think the best would be to expand this PR with a flag you can run during build to define if you want to build for long-running server process, or as a one-off job.

Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: emoritzx <emoritzx@gmail.com>
@kahst kahst merged commit 5610b92 into kahst:main May 27, 2022
@olipayne olipayne deleted the patch-1 branch May 28, 2022 12:19
Josef-Haupt pushed a commit to Josef-Haupt/BirdNET-Analyzer that referenced this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants