[dynamodb] sync-up with openhab1-addons repo and bnd dependencies #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, removed dependency to com.google.common.collect. Corresponding PRs: openhab#5847 and openhab#5826 Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
|
Two other points,
<bundle start-level="80">mvn:org.openhab.persistence/org.openhab.persistence.dynamodb/${project.version}</bundle>Shouldn't it be |
|
With <feature name="openhab-persistence-dynamodb" description="Amazon DynamoDB Persistence" version="${project.version}">
<feature prerequisite="true">wrap</feature>
<feature>openhab-runtime-base</feature>
<bundle start-level="80">mvn:org.openhab.addons.bundles/org.openhab.persistence.dynamodb/${project.version}</bundle>
<bundle dependency="true">wrap:mvn:com.amazonaws/aws-java-sdk-dynamodb/1.11.213$Bundle-Name=AWS%20Java%20SDK%20For%20Amazon%20DynamoDB&Bundle-SymbolicName=aws-java-sdk-dynamodb&Bundle-Version=1.11.213</bundle>
<configfile finalname="${openhab.conf}/services/dynamodb.cfg" override="false">mvn:${project.groupId}/openhab-addons-external/${project.version}/cfg/dynamodb</configfile>
</feature>I get different error message: |
kaikreuzer
approved these changes
Apr 28, 2019
kaikreuzer
pushed a commit
that referenced
this pull request
Oct 5, 2023
…hab#15547) * [jsscripting] Rename parameter useIncludedLibrary to injectionCachingEnabled (#4) * [jsscripting] Improve README for cached library injection * Remove settings image Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
org.openhab.persistence.dynamodbandorg.openhab.persistence.dynamodb.testprojects)pom.xmlandfeatures.xml. If I understand correctly, it might enough to declare dependency toaws-java-sdk-dynamodb-- this should pick up all the necessary transitive dependencies as well without specifiying them separately infeatures.xml(seeincludeTransitiveDependencyin https://svn.apache.org/repos/asf/karaf/site/production/manual/latest/karaf-maven-plugin.html).mvn installof the bundle works without errors. However,mvn installinopenhab2-addons/features/karaf/openhab-addonsoutputs the following:Any idea why this is?