[check for #426] Use AsBytes for copy_in, read_kernel #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
coolofficials
commented
Mar 28, 2021
| @@ -185,7 +186,11 @@ pub struct InodeGuard<'a> { | |||
| pub inode: &'a Inode, | |||
| } | |||
|
|
|||
| #[derive(Default)] | |||
| // It needs repr(C) for deriving zerocopy::AsBytes trait. | |||
| // DIRSIZ should match conditions for AsBytes. | |||
There was a problem hiding this comment.
DIRSIZ가 많이 커질 일은 없겠지만 그래도 AsBytes의 조건을 만족해야하기 때문에 명시했습니다.
| @@ -185,7 +186,11 @@ pub struct InodeGuard<'a> { | |||
| pub inode: &'a Inode, | |||
| } | |||
|
|
|||
| #[derive(Default)] | |||
| // It needs repr(C) for deriving zerocopy::AsBytes trait. | |||
There was a problem hiding this comment.
AsBytes를 derive 한 다른 타입들은 이미 repr(C)였기 때문에 AsBytes를 위해 repr(C)를 추가한 Dirent에만 이 코멘트를 추가했습니다.
| @@ -30,6 +30,7 @@ array-macro = "2.0.0" | |||
| static_assertions = "1.1.0" | |||
| itertools = { version = "0.10.0", default-features = false } | |||
| pin-project = "1" | |||
| zerocopy = { version = "0.3.0", default-features = false } | |||
There was a problem hiding this comment.
최신 버전은 0.4.0이지만 documentation은 0.3.0까지만 되어 있어서 0.3.0을 사용했습니다.
coolofficials
changed the title
coolofficials
commented
Mar 28, 2021
Comment on lines
414
to
+417
| /// # Safety | ||
| /// | ||
| /// `T` can be safely `transmute`d to `[u8; size_of::<T>()]`. | ||
| pub unsafe fn read_kernel<T>(&mut self, dst: &mut T, off: u32) -> Result<(), ()> { | ||
| /// https://docs.rs/zerocopy/0.3.0/zerocopy/trait.AsBytes.html |
There was a problem hiding this comment.
unsafe가 없어졌어도 Safety 코멘트를 남겨야 할 것 같아서 두었습니다. 대신 이걸 사용한 곳에서는 제거했습니다.
copy_in도 마찬가지입니다.
|
현재 확인한 바로는 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #426 의 의미를 파악하기 위한 draft pr 입니다.