Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select hex editor bytes when an instance in an array is selected #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pfroud
Copy link

@pfroud pfroud commented Apr 19, 2022

Example KSY file:

meta:
  id: array_selection_test
seq:
  - id: my_array
    type: my_type
    repeat: expr
    repeat-expr: 2
types:
  my_type:
    seq:
      - id: foo
        type: u1
      - id: bar
        type: u1

Present behavior: clicking on one of the MyType instances in the tree clears the hex editor selection and does not select anything.
image

New behavior: clicking on one of the MyType instances in the tree selects the corresponding bytes in the hex editor.
image

Behavior not changed:

  • Clicking on myArray in the tree selects the corresponding bytes in the hex editor. image
  • Clicking on one of the MyType fields in the tree selects the corresponding bytes in the hex editor.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant