fix: NVML unknown error #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuangqh
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
Fei-Guo
approved these changes
Oct 18, 2024
ishaansehgal99
had a problem deploying
to
unit-tests
GitHub Actions
Error
ishaansehgal99
approved these changes
Oct 18, 2024
see https://github.com/NVIDIA/nvidia-docker/issues/966\#issuecomment-610928514 Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
zhuangqh
force-pushed
the
upgrade-device-plugin
branch
from
b0d56c9 to
caae8a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 58.18% 54.45% -3.74%
==========================================
Files 30 34 +4
Lines 2987 3928 +941
==========================================
+ Hits 1738 2139 +401
- Misses 1149 1683 +534
- Partials 100 106 +6 ☔ View full report in Codecov by Sentry. |
Fei-Guo
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
see https://github.com/NVIDIA/nvidia-docker/issues/966#issuecomment-610928514
Requirements
Issue Fixed:
Notes for Reviewers: