Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
Signed-off-by: Kaituo Li <kaituo@amazon.com>
  • Loading branch information
kaituo committed Jun 24, 2024
1 parent f9cd3b0 commit 3b6090b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion build-tools/coverage.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jacoco {
}

/**
* This code sets up coverage reporting manually for the k-NN plugin tests. This is complicated because:
* This code sets up coverage reporting manually for the AD plugin tests. This is complicated because:
* 1. The OS integTest Task doesn't implement Gradle's JavaForkOptions so we have to manually start the jacoco agent with the test JVM
* 2. The cluster nodes are stopped using 'kill -9' which means jacoco can't dump it's execution output to a file on VM shutdown
* 3. The Java Security Manager prevents JMX from writing execution output to the file.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ public class ForecastEnabledSetting extends DynamicNumericSetting {
*/
public static final String FORECAST_ENABLED = "plugins.forecast.enabled";

// TODO: remove the field when releasing forecasting
public static boolean enabled = false;

public static final Map<String, Setting<?>> settings = unmodifiableMap(new HashMap<String, Setting<?>>() {
{
/**
Expand All @@ -56,10 +53,6 @@ public static synchronized ForecastEnabledSetting getInstance() {
* @return whether forecasting is enabled.
*/
public static boolean isForecastEnabled() {
// keep the dynamic setting in main branch to enable writing tests.
// will make it hardcoded false in the 2.x branch.
return ForecastEnabledSetting.getInstance().getSettingValue(ForecastEnabledSetting.FORECAST_ENABLED);
// TODO: enable forecasting before released
// return enabled;
}
}

0 comments on commit 3b6090b

Please sign in to comment.