Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parse errors #141

Closed
2 tasks
kaj opened this issue May 15, 2022 · 0 comments · Fixed by #201
Closed
2 tasks

Improve parse errors #141

kaj opened this issue May 15, 2022 · 0 comments · Fixed by #201

Comments

@kaj
Copy link
Owner

kaj commented May 15, 2022

Any errors discovered during parsing of scss (or css) input must pass through the nom error handing. It has two error-handling "modes", of which rsass till use the simple/limited one.

  • Switch to using nom::error::VerboseError
  • Fix as many invidual error messages as possible to match dart-sass for the test suite.
@kaj kaj mentioned this issue Oct 2, 2024
Merged
kaj added a commit that referenced this issue Oct 3, 2024
@kaj
Improved parse error handling
f56f11d 
Many parse errors now match the dart sass error message.  Also allow
"loud" comments in more places.

Use nom "verbose" error handling to build proper parse errors.

Fixes #141.
kaj added a commit that referenced this issue Oct 4, 2024
@kaj
Improved parse error handling
235ce6a 
Many parse errors now match the dart sass error message.  Also allow
"loud" comments in more places.

Use nom "verbose" error handling to build proper parse errors.

Fixes #141.
@kaj kaj closed this as completed in #201 Oct 5, 2024
@kaj kaj closed this as completed in d0fe994 Oct 5, 2024
kaj added a commit that referenced this issue Oct 5, 2024
@kaj
Proper errors from the parser. (#201)
09d80f2 
Use nom "verbose" error handling to build proper parse errors.

This should fix #141 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Proper errors from the parser. kaj/rsass
1 participant
@kaj