Improve selector functions #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve how arguments are recieved and resulting selectors are converted to values.
kaj
force-pushed
the
improve-selector-fns
branch
from
be093ad
to
3ec5d0f
Compare
kaj
added a commit
that referenced
this pull request
Jun 1, 2021
Progress: 3727 of 6171 tests passed in dart-sass compatibility mode. * `value::Unit` and `value::ListSeparator` has new alternatives. * The `List` alternative in `sass::Value` and `css::Value` is modified. * The `Use` alternative in `sass::Item` is modified, and `Forward` added. * Most of `@forward` and some more of `@use` is now supported. PR #109 and #110. * Handle unknown units. PR #101. * List can be undecided between beeing comma-separated and beeing space-separated. PR #102. * Improved parameter handling and returned values of the supported selector functions. PR #103. * Implement `meta.module_variables` and `meta.module_functions`. * Implement `math.div` function. * Improved parameter checking for `hwb`, `alpha`, and `invert` functions in `sass:color` module. * Support slash-separated lists. PR #111. * The `if` function evaluates its arguments lazily. Issue #107. * The `--include-path` cli argument is now named `--load-path`. * At least some documentation on all public items. * Update sass-spec test suite to 2021-05-24. Also include "other" files (for `@use` and `@import`) in rust code for the suite. Tested with rustc 1.52.1, 1.50.0, 1.48.0, 1.45.2, 1.53.0-beta.3 (82b862164 2021-05-22), and 1.54.0-nightly (657bc0188 2021-05-31).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve how arguments are recieved and resulting selectors are converted to values.
Also improve how backrefs are handled in PseudoElement and Pseudo selectors.