Enable clippy in CI. #128
Merged
Enable clippy in CI. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaj
added a commit
that referenced
this pull request
Mar 23, 2022
Released 2022-03-23. Progress: 4013 of 6478 tests passed in dart-sass compatibility mode. ### Breaking changes * The functions `parse_scss_file` and `parse_scss_path` is removed. Use `SourceFile` (maybe from a `FileContext`) instead (PR #132). * Some API changes (mayinly using `SourceFile` as return type) in `FileContext` and `FsF ileContext` (PR #132). * `Scope::get` now takes an `&Name` rather than an `&str` for the variable name. * `sass::Value::Variable` now has a source position. * `sass::Item` and `css::BodyItem` got new alternatives for custom properties (PR #134). * Some changes in the `Error` type to facilitate positions. ### Improvements * Basic support for `meta.load-css` mixin (PR #131). * Improved `calc` and `clamp` handling (PR #133). * Support custom properties (PR #134). * Refactor source file handling. Instead of creating new FileContexts wrapping the original for each file for searching for local paths in that file, use the SourceName of the containing file to find local paths (PR #132). * Detect `@import` loops. * Report undefined variable / module errors better. * Update color formatting. Sass-spec changed how it decides what format to show a color in (PR #135). * Enable clippy in CI and fix some things it complained about (PR #128). * Update sass-spec test suite to 2022-03-17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See if clippy works as a github action.