Arbitrary precision #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I still think this area requires more work, I'm now pretty sure I consider this PR a step in the right direction. So I will merge it and think of other steps later. |
kaj
added a commit
that referenced
this pull request
Oct 3, 2020
Progress: 2234 of 5510 tests passed in dart-sass compatiblilty mode. * PR #76 and #78: Target dart-sass rather than libsass compatibilty. This sets the target when testing and changes some different behaviour, including how strings are parsed and handled. * PR #75 from @divergentdave: Parse and add `Value` variants for BigInt numbers * PR #77: Support `rgba(r g b / a)` and `hsla(h s l / a)` functions, i.e. the `channels` parameter with div-separated alpha channel. * Fix `@import` indention. * Improve function default argument parsing and dont panic in `parse_value_data`. * Handle dictionary-ellipsis style call-by-varargs for functions. * PR #73 from @divergentdave: Remove three unwraps from escaped_char * PR #71 from @connorskees: Further optimize number printing * Update travis url in README. * PR #70 from @svenstaro: Mention grass rather than sassers, as sassers appears to be dead while grass is in rather active development. * Add a CHANGELOG.md * Update spec to 2020-09-17. * Update num-rational to 0.3.0. Tested with rustc 1.46.0 (04488afe3 2020-08-24), 1.44.1 (c7087fe00 2020-06-17), 1.42.0 (b8cedc004 2020-03-09), 1.40.0 (73528e339 2019-12-16), 1.38.0 (625451e37 2019-09-23), 1.47.0-beta.7 (e28d2bd09 2020-10-01), and 1.48.0-nightly (8876ffc92 2020-10-02)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #74 by adding variants to sass::Value and css::Value for arbitrary precision numbers, and outputting those from the parser as a fallback when isize overflows.