Handle @use module as *.
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaj
added a commit
that referenced
this pull request
Jan 29, 2021
Progress: 2784 of 5936 tests passed in dart-sass compatiblilty mode. ## Breaking changes * Update nom to 6.0 rasises the minimally supported compiler version to 1.44.0. Also, the dependency is technically exposed. * `sass::Item::Use` was modified by #84. * `compile_scss_file` is renamed to `compile_scss_path`, and `FileContext` is now a trait, the default implementation is renamed to `FsFileContext` by #85. ## Improvements * Allow customizing file loading by providing a custom impl of a `FileContext`, PR #85. * Support the `@use name as *` syntax, PR #84. * Make `Error::BadValue` a little closer to whats expected. * Handle units in `@for` loops. * Update `nom` to 6.0, PR #83. * Update `rand` to 0.8, PR #86. * Testing is now done with github actions rather than travis (Appveyor remains for window builds). * sass-spec test suite updated to 2021-01-20. Thanks to @paolobarbolini and @alvra for code contributions. Tested with rustc 1.49.0 (e1884a8e3 2020-12-29), 1.44.1 (c7087fe00 2020-06-17), 1.46.0 (04488afe3 2020-08-24), 1.48.0 (7eac88abb 2020-11-16), 1.50.0-beta.8 (1cd030396 2021-01-20), and 1.51.0-nightly (c0b64d97b 2021-01-28).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, loading a module that cannot be loaded is an error (a nonexistent (new?) standard module, an extension for another implementation, or any user-provided module, since those are not yet supported).