Refactor scopes #95
Merged
Refactor scopes #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using the GlobalScope outside variablescope.rs.
A global scope is just a ScopeImpl with no parent.
kaj
added a commit
that referenced
this pull request
Feb 25, 2021
Progress: 2892 of 5945 tests passed in dart-sass compatibility mode. ### Breaking changes Lots of things have been moved around. See `Scope`, `Numeric`, and `Function` in particular. ### Improvements * Support `@use` of user-defined modules. PR #96. * Improve trigonometric precision by using f64 π rather than rational. * Handle more peculiarities with atan2, pow, infinities and negative zero. * Improve name lookups in scopes and modules, PR #87. * new `struct Scope` replaces trait and three structs. PR #95. * A color can be Hsla or Hwba as well as Rgba. PR #88, #89. * Handle units in `@for` loops inside sass functions. * Some types moved into `value` mod, imporoved docs. PR #90. * Add support for `$=`, `~=` and `^=` in css attribute selectors. Issue #91, PR #92. * A `Numeric` is a Number with a Unit. Also hide NumValue enum. PR #93. * The `SassFunction` type is now named `sass::Function`. * Test suite sass-spec updated to 2021-02-18. * Some cleanups. Thanks to @mfeckie for #91/#92. Tested with rustc 1.50.0 (cb75ad5db 2021-02-10), rustc 1.48.0 (7eac88abb 2020-11-16), rustc 1.46.0 (04488afe3 2020-08-24), rustc 1.44.1 (c7087fe00 2020-06-17), rustc 1.51.0-beta.3 (b631c914c 2021-02-24), and rustc 1.52.0-nightly (a8486b64b 2021-02-24).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify
trait Scopeand the structsScopeImpl,GlobalScopeandModuleto a singlestruct Scope.