Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp proxy callback api to be easily extends #122

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

kakawait
Copy link
Owner

@kakawait kakawait commented Sep 4, 2019

Open some classes to public and add ability to programmatically edit proxy callback

@kakawait kakawait added this to the 1.0.0 milestone Sep 4, 2019
@kakawait kakawait self-assigned this Sep 4, 2019
@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #122 into develop will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #122      +/-   ##
=============================================
+ Coverage      84.51%   84.77%   +0.26%     
- Complexity       118      121       +3     
=============================================
  Files             23       23              
  Lines            607      611       +4     
  Branches          78       78              
=============================================
+ Hits             513      518       +5     
  Misses            69       69              
+ Partials          25       24       -1
Impacted Files Coverage Δ Complexity Δ
...CallbackAndServiceAuthenticationDetailsSource.java 100% <100%> (ø) 3 <2> (+1) ⬆️
...tProxyCallbackAndServiceAuthenticationDetails.java 100% <100%> (+5%) 8 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 600cfd7...491aa69. Read the comment docs.

Open some classes to public and add ability to programmatically edit proxy callback
@kakawait kakawait force-pushed the enhancement/dynamic-proxy-callback-api branch from 6edb44d to 491aa69 Compare September 4, 2019 19:46
@kakawait kakawait merged commit c818717 into develop Sep 4, 2019
@kakawait kakawait deleted the enhancement/dynamic-proxy-callback-api branch January 31, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant