Updated for FRITZ-Dect 500 devices #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaklakariada
requested changes
Dec 2, 2020
| @@ -39,6 +39,7 @@ public Deserializer() { | |||
| } | |||
|
|
|||
| public <T> T parse(String data, Class<T> resultType) { | |||
| //LOG.info("parsing data:"+data); | |||
There was a problem hiding this comment.
Please don't add commented code
Suggested change
| //LOG.info("parsing data:"+data); |
There was a problem hiding this comment.
has been removed, sorry for that.
| public void parseDeviceListFritzDect200() throws IOException { | ||
| final String fileContent = Files.readAllLines(Paths.get("src/test/resources/deviceListConnectedFritzDect200Payload.xml")).stream() | ||
| .collect(joining("\n")); | ||
| new Deserializer().parse(fileContent, DeviceList.class); |
kaklakariada
approved these changes
Dec 4, 2020
|
I will build a new release soon, maybe on the weekend. |
kaklakariada
added a commit
that referenced
this pull request
Dec 6, 2020
|
Published 1.2.1 to jcenter: https://jcenter.bintray.com/com/github/kaklakariada/fritzbox-java-api/1.2.1/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with this lib i noticed that some of the newer devices are not supported.