Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new command "getdeviceinfo" #39

Merged
merged 4 commits into from
May 9, 2022
Merged

Conversation

odin568
Copy link
Contributor

@odin568 odin568 commented Mar 16, 2022

Hi,
there was already a method to get all deviceinfos as a list. When I know the ain, I would like to use the method to get exactly the one device to avoid later filtering.
Beside that, for easier handling, I made FritzBoxSession public - don't know if it was by purpose package private. Makes it easier to quickly try out stuff in my app.
Reach out to me on questions!
BR, odin568

Copy link
Owner

@kaklakariada kaklakariada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR and sorry for the late reply!
Please add an entry to the "unreleased" section of the changelog with a description of your change and (if you want) your user name as attribution.

@odin568
Copy link
Contributor Author

odin568 commented May 9, 2022

Done.
Thank you!

@kaklakariada kaklakariada self-requested a review May 9, 2022 15:50
@kaklakariada kaklakariada merged commit 027d8dd into kaklakariada:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants