Permit override of package names #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for CentOS 6 hosts (3.x is simply too old).
…e classic class parameters instead.
Samba-4.7.1-9 causes winbind to fail to start without a domain being already joined, which is rather annoying and generates build problems for us.
|
Also added a dependency on the options being set before the domain join exec, as sometimes we were getting an incomplete config when this tried to run... |
… list and Foreman logs (from btolab/puppet-samba fork).
… via environment variable instead of explicitly on command-line.
…the old/existing behaviour back as it was...
* 'master' of github.com:kakwa/puppet-samba: match PUPPET_VERSION in travis.yml to Gemfile setting fix travis test to actually sets the puppet version Update travis.yml to include new versions of ruby and puppet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS 6 has samba4-* packages, but rather than adding explicit support for these packages it is more flexible to allow changing of the package names from the default versions.
(If you have the samba-* default packages installed for 3.x on CentOS 6, then these conflict and so you need to forceably remove the old packages before installing these, which I wouldn't want to add to this module... :)
This change is