New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Debian 10 #71

Open

antondollmaier wants to merge 1 commit into kakwa:master from antondollmaier:master

antondollmaier commented Feb 11, 2020 •

edited by kakwa

Loading

Hi,

thanks for your great module!

On Debian 10, it fails to start the SMB service: in the params.pp, the string comparison of "10" vs "8" fails, so the wrong service name is picked.

Changes:

use versioncmp() to actually support Debian 10
unified parameter name to international version (my french is not the best, so I'm uncertain if this was a very consequent typo, or intentional. the parameter now matches the service resource.)

This change is


          Support Debian 10

6cc09b3

use versioncmp() to actually support Debian 10

unified parameter name to international version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet