-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[make_voxceleb1.pl] Fix train/test data split for the latest version of the voxceleb1 dataset #3249
Conversation
(+) if previous script is still needed, I can use this modified script to another version (ex. v2) rather than replacing the existing script. |
Thanks a lot!! @david-ryan-snyder can you please check this? |
Thanks @sunshines14. Could you do what you offered and copy this to a new script called make_voxceleb1_v2.pl? Then, in the run.sh script, make the v2 script the default one. Comment out the the old version of the script, and above it write a short comment describing the situation. E.g., mention that if you downloaded the dataset soon after it was released, you will want to use the make_voxceleb1.pl script instead. |
Thanks @david-ryan-snyder. I fixed some code as you commented as follows:
It was reconfirmed that successful output can be obtained from all of fixed scripts. |
Thanks @sunshines14! I just suggested you credit your work in the v2 perl script and fix a preexisting typo. Then we can merge it. |
I did it all. |
Thanks @sunshines14, looks good to me. @danpovey, I think it's fine to merge this. |
I found that previous scripts do not work with the latest version of the voxceleb1 dataset.
Therefore, I fixed the script for the latest version as follows:
It is confirmed that successful output can be obtained from the script.
ex) voxceleb1_test -- spk2utt, trials, utt2spk, wav.scp