make nonconst catches const #4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging, thanks @csukuangfj |
rkjaran
added a commit
to tiro-is/kaldi
that referenced
this pull request
Sep 27, 2024
* upstream/master: (76 commits) [CI] Automatically refresh docker images (kaldi-asr#4942) make sure nvtx3 is used (kaldi-asr#4937) [CI] Upgrade checkout action (kaldi-asr#4940) Upload logs after build failure (kaldi-asr#4939) upload the error logs to artifact repository (kaldi-asr#4938) fix cuda build with openfst 1.8.3 (kaldi-asr#4936) fix the non-compiling tests, thx to @csukuangfj add support for later openfst versions make nonconst catches const (kaldi-asr#4926) Support openfst-1.8.2 Support openfst-1.8.1 Support openfst-1.8.0 Support openfst-1.7.6 make codefactor happier improve compatibility with C++ standard, esp. C++20 do a full cleanup on apple silicon disable warning about unused flags msse and msse on Apple Silicon fix tests and address comments catch exception by reference so that compiler does not complain Fix reported issues w.r.t python2.7 and some apple silicone quirks ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix I didn't think about yesterday -- grepped for all nonconst catches, found only these two.