Skip to content

Commit

Permalink
Don't start the BFT mining coordinator when it is created, just enabl…
Browse files Browse the repository at this point in the history
…e it (hyperledger#6675)

* Don't start a BFT mining coordinator when it is created, just enable it

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>

* Update change log

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>

---------

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io>
  • Loading branch information
matthew1001 committed Jun 7, 2024
1 parent aa114da commit 2269b7d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

### Bug fixes
- Make block transaction selection max time aware of PoA transitions [#6676](https://github.com/hyperledger/besu/pull/6676)
- Don't enable the BFT mining coordinator when running sub commands such as `blocks export` [#6675](https://github.com/hyperledger/besu/pull/6675)

### Download Links

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,7 @@ protected MiningCoordinator createMiningCoordinator(
.getBlockPeriodSeconds()));

if (syncState.isInitialSyncPhaseDone()) {
LOG.info("Starting IBFT mining coordinator");
ibftMiningCoordinator.enable();
ibftMiningCoordinator.start();
} else {
LOG.info("IBFT mining coordinator not starting while initial sync in progress");
}

syncState.subscribeCompletionReached(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -286,11 +286,7 @@ protected MiningCoordinator createMiningCoordinator(
.getBlockPeriodSeconds()));

if (syncState.isInitialSyncPhaseDone()) {
LOG.info("Starting QBFT mining coordinator");
miningCoordinator.enable();
miningCoordinator.start();
} else {
LOG.info("QBFT mining coordinator not starting while initial sync in progress");
}

syncState.subscribeCompletionReached(
Expand Down

0 comments on commit 2269b7d

Please sign in to comment.