Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the right element to get LitElement from #50

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Conversation

bramkragten
Copy link
Contributor

@bramkragten bramkragten commented Apr 30, 2021

The home-assistant element is not a normal LitElement, but has a bunch of mixins giving unwanted side effects.

Besides that, hui-view is no longer a LitElement but a UpdatingElement, so should not be used as a fallback.

The `home-assistant` element is not a normal LitElement, but has a bunch of mixins giving unwanted side effects
@kalkih kalkih changed the base branch from master to dev April 30, 2021 23:50
@kalkih
Copy link
Owner

kalkih commented Apr 30, 2021

Great, thanks!

@kalkih kalkih merged commit 040e44d into kalkih:dev Apr 30, 2021
@hmmbob
Copy link

hmmbob commented May 1, 2021

@kalkih could you possibly tag a new release with this fix? Without it, the card is making my theme revert to dark mode everytime the card is displayed 😉

I only have seen the issue on 2021.5.0 beta release so far, which makes me believe more users will be affected as soon as 2021.5 ships (coming Wednesday).

Thanks for creating great stuff!

@kalkih
Copy link
Owner

kalkih commented May 1, 2021

Hey @hmmbob , thanks for letting me know, will create a release later today 👍

@hmmbob
Copy link

hmmbob commented May 1, 2021

Much appreciated, thanks!

@Mariusthvdb
Copy link

Mariusthvdb commented May 1, 2021

@kalkih could you possibly tag a new release with this fix? Without it, the card is making my theme revert to dark mode everytime the card is displayed 😉

I only have seen the issue on 2021.5.0 beta release so far, which makes me believe more users will be affected as soon as 2021.5 ships (coming Wednesday).

Thanks for creating great stuff!

yes! thats exactly what I saw yesterday, couldn't find the logic to it though...more-over it doesnt do that right now, so some mystery still going on...

@bramkragten please allow me to ask if that is something that needs to be changed here and here in custom-ui too?

@bramkragten
Copy link
Contributor Author

@bramkragten please allow me to ask if that is something that needs to be changed here and here in custom-ui too?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants