Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database handling improved for Alternate Gateways #149

Merged
merged 4 commits into from
Jun 7, 2014

Conversation

jbubik
Copy link
Contributor

@jbubik jbubik commented Jun 2, 2014

Implemented improvements for proof-of-concept features discussed in issue #60
Tested in a small community deployment. Works reliably.
Needs a crontab job for sending postponed messages. New scripts supplied.
Enjoy! Jan

jbubik added 3 commits May 24, 2014 20:24
There was interresting development done in the NEW-GATEWAY branch.
Sadly NEW-GATEWAY branch was based on Kalkun 0.6
This commit brings old development into current MASTER branch.
Intended to be a fresh start for more coding :-)
Idea based on Kamil Paral's esmska project. Credit to him.
PHP/CURL implementation by jbubik - heavily based on existing direct
gateway scripts way2sms_model.php and gammu_model.php
Security consideration: your system/cache folder MUST be protected
Without proper .htaccess file, your stored cookies are publicly
accessible via HTTP. Anyone could send via your account!
Added nongammu_model.php as a superclass for all Alternative Gateways.
Implemented:
 - a stub function for sending message (really_send_massages())
 - saving a message to sentitems after sending
 - saving a message into outbox for to-be-postponed messages
 - processing of postponed messages from outbox
 - crontab script for periodic executing
@back2arie
Copy link
Collaborator

Hi, i see change on some file like htaccess and some shell script, is this related on this feature?

@back2arie
Copy link
Collaborator

Ah, just had quick preview on commit message and it's looks like pretty clear now. Will do some testing again just to make sure. Thx for your great effort!

@jbubik
Copy link
Contributor Author

jbubik commented Jun 4, 2014

Well, it comes to my mind again - the whole directory structure of kalkun is visible via HTTP. Would it be possible to move DocumentRoot into some subdirectory? From security point of view the less files directly accessible the better. You may find some info in CI doku or here: http://stackoverflow.com/questions/17628180/codeigniter-setting-up-directories-and-files-permissions-chmod-settings

@jbubik
Copy link
Contributor Author

jbubik commented Jun 4, 2014

I simply like kalkun from first moments. And I needed exactly such a tool for a small but growing community (not IT related). Sending notifications via SMS is easy, cheap and "polite". There will be some more things I plan to do :-)

@back2arie
Copy link
Collaborator

Well we are might not aware of that, write it on the Wiki might be good idea :)
Thanks, merged.

back2arie added a commit that referenced this pull request Jun 7, 2014
Database handling improved for Alternate Gateways
@back2arie back2arie merged commit c07d04c into kalkun-sms:master Jun 7, 2014
@jbubik
Copy link
Contributor Author

jbubik commented Jun 8, 2014

see Making Kalkun more secure in wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants