Merge pull request #163 from kalmarek/setindex-cleanup

Make setindex! always use set!
kalmarek · Aug 4, 2023 · 8a0be1a · 8a0be1a
2 parents a9c2406 + 9273ff9
commit 8a0be1a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 11 deletions.
diff --git a/src/matrix.jl b/src/matrix.jl
@@ -45,7 +45,6 @@ Base.@propagate_inbounds function Base.setindex!(
     i::Integer,
     j::Integer,
 )
-    @boundscheck checkbounds(A, i, j)
     ref(A, i, j)[] = x
     return x
 end
@@ -97,7 +96,6 @@ Base.@propagate_inbounds function Base.setindex!(
     i::Integer,
     j::Integer,
 )
-    @boundscheck checkbounds(A, i, j)
     ref(A, i, j)[] = x
     return x
 end

diff --git a/src/setters.jl b/src/setters.jl
@@ -1,3 +1,6 @@
+# Use res[] = x as short hand for Arblib.set!(res, x)
+Base.setindex!(res::Union{MagLike,ArfLike,ArbLike,AcbLike}, x) = set!(res, x)
+
 # Mag
 set!(res::MagLike, x::Integer) = set!(res, convert(UInt, x))
 set!(res::MagLike, ::Irrational{:π}) = const_pi!(res)

diff --git a/src/types.jl b/src/types.jl
@@ -305,10 +305,3 @@ const ArbTypes = Union{
     AcbPoly,
     AcbSeries,
 }
-
-Base.setindex!(x::Union{Mag,MagRef,Arf,ArfRef,Arb,ArbRef,Acb,AcbRef}, z::Number) =
-    set!(x, z)
-Base.setindex!(x::MagOrRef, z::Ptr{mag_struct}) = set!(x, z)
-Base.setindex!(x::ArfOrRef, z::Ptr{arf_struct}) = set!(x, z)
-Base.setindex!(x::ArbOrRef, z::Ptr{arb_struct}) = set!(x, z)
-Base.setindex!(x::AcbOrRef, z::Ptr{acb_struct}) = set!(x, z)
diff --git a/src/vector.jl b/src/vector.jl
@@ -38,7 +38,6 @@ Base.@propagate_inbounds function Base.setindex!(
     x,
     i::Integer,
 )
-    @boundscheck checkbounds(v, i)
     ref(v, i)[] = x
     return x
 end
@@ -84,7 +83,6 @@ Base.@propagate_inbounds function Base.setindex!(
     x,
     i::Integer,
 )
-    @boundscheck checkbounds(v, i)
     ref(v, i)[] = x
     return x
 end