Fix codecov integration #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devmotion Thanks for detailed info and instructions! I've added the token to the repo. I'd personally change |
|
Changing |
devmotion
commented
Apr 18, 2024
|
@devmotion and now macOS fails as it tries to use (the non-existent) token from your fork? the other ones just resolve to tokenless upload. Is this ok to be merged? EDIT: seems that the coverage was updated on codecov successfully! |
|
An alternative to |
|
I'm fine with simple |
kalmarek
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#188 broke codecov integration: Version 4 of the action does not support tokenless iploads anymore. Thus currently codecov uploads will always fail, see eg https://github.com/kalmarek/Arblib.jl/actions/runs/8724232667/job/23934347761#step:8:34. This error was masked by the
fail_ci_if_error: false, so you might want to consider changing it totrue(at the cost of spurious test failures sometimes since codecov servers are not completely reliable in my experience).To fix codecov integration, in addition to this PR you have to go to the codecov webpage, navigate to the settings for this repo, and copy the token shown there to a Github repo secret named
CODECOV_TOKEN.