Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Support ja in website #353

Merged
merged 3 commits into from
Aug 13, 2021
Merged

docs: Support ja in website #353

merged 3 commits into from
Aug 13, 2021

Conversation

kamiazya
Copy link
Owner

No description provided.

@kamiazya kamiazya added the documentation Improvements or additions to documentation label Aug 13, 2021
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@@ -93,7 +93,7 @@ You can use the yarn command to install packages and initialize projects with a
2 directories, 9 files
```

<img src={require('./assets/MyInfra.rediagram.png').default} />
<img src={require('../../assets/MyInfra.rediagram.png').default} />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

2 directories, 9 files
```

<img src={require('../../../../../assets/MyInfra.rediagram.png').default} />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@kamiazya kamiazya merged commit f465051 into master Aug 13, 2021
@kamiazya kamiazya deleted the website-ja branch August 13, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant