Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure default argument values are printable #2017

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

ertrzyiks
Copy link
Contributor

@ertrzyiks ertrzyiks commented Sep 28, 2021

Description

Make use of the util introduced in #1959 to prevent runtime exceptions during printing default value change.

Fixes #2016

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • n/a New feature (non-breaking change which adds functionality)
  • n/a Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • n/a This change requires a documentation update

How Has This Been Tested?

With unit test

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Sep 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/inspector-org/graphql-inspector/8g7VyXxj7PqSQreyFuE1FW32r692
✅ Preview: https://graphql-inspector-git-fork-ertrzyiks-issue-2016-inspector-org.vercel.app

@kamilkisiela
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot convert object to primitive value in GHA
2 participants