Added diff support for arrays and objects #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilkisiela
requested changes
Mar 8, 2019
Co-authored-by: Andreas Hubel andreas.hubel@br.de
mkaradeniz
commented
Mar 8, 2019
| @@ -382,3 +382,145 @@ test('', () => { | |||
| } | |||
| }); | |||
| }); | |||
|
|
|||
| test('array as default value in argument (same)', () => { | |||
There was a problem hiding this comment.
Before this pr, these arrays would've been marked as different.
mkaradeniz
commented
Mar 8, 2019
mkaradeniz
commented
Mar 8, 2019
kamilkisiela
approved these changes
Mar 10, 2019
|
Thank you, I'll release it today :) |
|
Hey, do you know when you'll get around releasing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When diffing
defaultValue, we sometimes get an object or array back. Added custom handling for such cases.Co-authored-by: Andreas Hubel andreas.hubel@br.de