Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump byte-buddy, gradle, lombok #159

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hughsimpson
Copy link
Contributor

@hughsimpson hughsimpson commented Aug 30, 2024

Bumps some dependencies

I built byte-buddy off this manually applied diff with byte-buddy 15.1 according to the comments on this pr. I didn't apply the commented-out maven-shade-plugin from that diff, since that seemed like a mistake? Used Java version 1.8.0_392 (OpenJDK Runtime Environment (Zulu 8.74.0.17-CA-macos-aarch64) (build 1.8.0_392-b08)) to build the byte-buddy jar.

Perhaps, in the future, it would be possible to write a manually-triggered github action to do this (i.e. pass it a byte-buddy tag, and have it clone the repo, check out that tag, apply the diff, build the artifact, and pr the jars) so that provenance could be better ascertained... Obviously I haven't done that leg-work in this pr.

Other changes:

  • bumped gradle to 8.10
  • replaced |& with 2>&1 | because the former doesn't work on macos :'(
  • lombok to 1.18.34

@hughsimpson hughsimpson changed the title Bump byte-buddy and gradle Bump byte-budd, gradle, lombok Aug 30, 2024
@hughsimpson hughsimpson changed the title Bump byte-budd, gradle, lombok Bump byte-buddy, gradle, lombok Aug 30, 2024
@hughsimpson
Copy link
Contributor Author

hughsimpson commented Sep 6, 2024

@ivantopo @dpsoft I'm about to do a thing with another repo where it has to make a pr to yet another repo when a certain file changes. Once I do that thing, it'll probably be easy enough to do a similar thing here and make the jar construction traceable. Might do that instead for byte-buddy.

Edit: attempt that flow here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant