Revert "CatalogBuilder::new_chained(): pass "chained_catalog" by value"

This reverts commit 94530f9.
kamu-data · Jun 20, 2024 · 66512d4 · 66512d4
1 parent b47c119
commit 66512d4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/dill/src/catalog_builder.rs b/dill/src/catalog_builder.rs
@@ -34,11 +34,11 @@ impl CatalogBuilder {
         }
     }
 
-    pub fn new_chained(chained_catalog: Catalog) -> Self {
+    pub fn new_chained(chained_catalog: &Catalog) -> Self {
         Self {
             builders: HashMap::new(),
             bindings: MultiMap::new(),
-            chained_catalog: Some(chained_catalog),
+            chained_catalog: Some(chained_catalog.clone()),
         }
     }
 

diff --git a/dill/tests/tests/test_catalog.rs b/dill/tests/tests/test_catalog.rs
@@ -183,7 +183,7 @@ fn test_chained_catalog_binds() {
         .bind::<dyn B, BImpl>()
         .build();
 
-    let cat_later = CatalogBuilder::new_chained(cat_earlier.clone())
+    let cat_later = CatalogBuilder::new_chained(&cat_earlier)
         .add::<AImpl>()
         .bind::<dyn A, AImpl>()
         .build();

diff --git a/dill/tests/tests/test_scopes.rs b/dill/tests/tests/test_scopes.rs
@@ -138,7 +138,7 @@ fn test_chained_singleton() {
         .bind::<dyn A, AImpl>()
         .build();
 
-    let cat_later = dill::CatalogBuilder::new_chained(cat_earlier.clone())
+    let cat_later = dill::CatalogBuilder::new_chained(&cat_earlier)
         .add_value(BImpl::new("unique".to_string()))
         .bind::<dyn B, BImpl>()
         .build();