Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed linter pedantic warnings #10

Closed

Conversation

s373r
Copy link
Member

@s373r s373r commented May 27, 2024

No description provided.

@s373r s373r self-assigned this May 27, 2024
@sergiimk
Copy link
Member

Appreciate the linter setup and fixes, but please provide the motivation for the new_chained change in the PR description.

@s373r s373r changed the title CatalogBuilder::new_chained(): pass "chained_catalog" by value Fixed linter pedantic warnings Jun 20, 2024
Copy link
Member

@sergiimk sergiimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sergiimk sergiimk closed this Jun 20, 2024
@sergiimk sergiimk deleted the chore/CatalogBuilder__new_chained()_pass_catalog_by_value branch June 20, 2024 14:58
@sergiimk
Copy link
Member

This was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants