-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace println!
from library functions with configurable logging
#424
Replace println!
from library functions with configurable logging
#424
Conversation
Developers building on this crate do not necessarily need logging to occur over `println!` when authenticating 2FA, so this commit replaces the print macros with logging macros
It looks like there's some CI failures unrelated to this change:
|
@Firstyear how's this one look? Figured I'd ask because you've used it more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually @micolous would be the person to ask. There are some places where I think we use these messages as communication points for cli tools.
All the other backends use The CLI tools I wrote touch the other backends (as they need to interact with it on a CTAP2 level, rather than an "Authenticator" level), so this would at least make things consistent (as they will eventually replace the Mozilla backend). I believe the main user of the Mozilla backend is Kanidm's CLI tools – I don't know what makes sense there. |
Libraries really should use the |
Developers building on this crate do not necessarily need logging to occur over
println!
when authenticating 2FA, so this commit replaces the print macros with logging macrosFixes #