Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade hyper/http, use new APIs #458

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

micolous
Copy link
Collaborator

@micolous micolous commented Dec 11, 2024

Note: it compiles, but I need to test with physical hardware.

Upgrades http, http-body-util and hyper to current versions.

hyper switched from using Tokio traits to their own custom traits a while ago, but have an adapter to Tokio traits (hyper-util). So this switches everything to use the adapter.

Related to #444

  • cargo test has been run and passes
  • documentation has been updated with relevant examples (if relevant)

@Firstyear Firstyear mentioned this pull request Dec 11, 2024
2 tasks
@Firstyear
Copy link
Member

@micolous Given how much this PR is blocking I think we should merge it and commit to testing later.

@micolous
Copy link
Collaborator Author

micolous commented Dec 18, 2024

I can't actually find all the hardware pieces I need to test this properly. 😞

cable-tunnel-server-* is mostly a proof-of-concept demo rather than anything intended for serious usage, so I'm less worried if something breaks.

CI was failing because fido-hid-rs has a transitive dependency on home, which as part of cargo, has an MSRV-3 policy (=1.81), which is higher than our MSRV (=1.79).

#461 bumps the MSRV to 1.81. I've included that patch in this PR as well to make the build pass.

If you're happy with that, we can merge #461 first, then this on top.

Copy link
Member

@yaleman yaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit to me, dependency has been merged as noted

@micolous micolous changed the title wip: upgrade hyper/http, use new APIs Upgrade hyper/http, use new APIs Dec 18, 2024
@micolous micolous marked this pull request as ready for review December 18, 2024 07:43
@micolous micolous merged commit 1347c6c into kanidm:master Dec 18, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants