This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Issue #249: Fixed issue on provider producer function when reusing with different… #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I mentioned before, this is just covering up a bigger issue. We need tests to ensure that injections are applied correctly to the component hierarchy. I will look a little closer this week as we would like to update this dep, but cannot until this gets fixed |
|
@gmoneh |
gmoneh
added a commit
to gmoneh/vue-property-decorator
that referenced
this pull request
Jun 16, 2020
gmoneh
added a commit
to gmoneh/vue-property-decorator
that referenced
this pull request
Jun 16, 2020
…s and added unit tests for the bugs fixed.
kaorun343
added a commit
that referenced
this pull request
Jun 28, 2020
Resubmission of PR #299: As requested, indented with 2 spaces and added unit tests for the bugs fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of 8.4.0, I discovered a bug in the code I submitted for this issue had a bug that manifests when the component is instantiated a second time. The code submitted on this Pull Request fixes that issue.