Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add panner node into play() pipeline #331

Merged
merged 3 commits into from
Aug 11, 2024

Conversation

dragoncoder047
Copy link
Contributor

closes #304

@dragoncoder047 dragoncoder047 changed the title add panner node into play() pipeline feat: add panner node into play() pipeline Aug 7, 2024
@lajbel lajbel changed the base branch from master to v3001 August 7, 2024 21:50
@lajbel
Copy link
Collaborator

lajbel commented Aug 7, 2024

why is gainNode not used anymore?

@dragoncoder047
Copy link
Contributor Author

No, is still used, source connects to pan node, pan node connects to gain node, gain connects to output.

Copy link

pkg-pr-new bot commented Aug 7, 2024

commit: 152931f

pnpm add https://pkg.pr.new/kaplayjs/kaplay@331

Open in Stackblitz

@lajbel
Copy link
Collaborator

lajbel commented Aug 8, 2024

you should open a PR with the same changes but for master

@dragoncoder047
Copy link
Contributor Author

you should open a PR with the same changes but for master

I did originally base this pr against master, you switched it!

@lajbel
Copy link
Collaborator

lajbel commented Aug 8, 2024

IK, what I mean is create another PR because it's a change compatible with v4000 and v3001

@lajbel
Copy link
Collaborator

lajbel commented Aug 8, 2024

This should be only for v3001, shouldn't merge with master

@lajbel
Copy link
Collaborator

lajbel commented Aug 8, 2024

@dragoncoder047
Copy link
Contributor Author

IK, what I mean is create another PR because it's a change compatible with v4000 and v3001

so you mean merge this into v3001, and then do the same changes but on master?

@niceEli
Copy link
Member

niceEli commented Aug 9, 2024

the error is not fault of the pr. its a pkg.pr.new issue

@lajbel
Copy link
Collaborator

lajbel commented Aug 9, 2024

IK, what I mean is create another PR because it's a change compatible with v4000 and v3001

so you mean merge this into v3001, and then do the same changes but on master?

You should replicate the same changes for every branch, master and v3001, then open 2 PR's

@dragoncoder047 dragoncoder047 changed the base branch from v3001 to master August 9, 2024 13:18
@dragoncoder047
Copy link
Contributor Author

You should replicate the same changes for every branch, master and v3001, then open 2 PR's

Ok, I switched this one back to master to keep the commit history clean, will open another pr for v3001 soon

@niceEli
Copy link
Member

niceEli commented Aug 11, 2024

is ready for merge?

@niceEli
Copy link
Member

niceEli commented Aug 11, 2024

btw you dont really need to worry about commit history as it just gets squashed and merged into 1 commit anyway

@lajbel lajbel merged commit 7a1f2c6 into kaplayjs:master Aug 11, 2024
1 check failed
@dragoncoder047 dragoncoder047 deleted the patch-1 branch August 11, 2024 14:41
dragoncoder047 added a commit to dragoncoder047/kaplay that referenced this pull request Sep 7, 2024
kaplayjs#331 / kaplayjs#335 implemented the panning but I just noticed that if the audio is paused/stopped/seeked the audio will stop going through the pan node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Stereo pan option for play()
4 participants