-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add panner node into play() pipeline #331
Conversation
implements my idea in kaplayjs#304
why is gainNode not used anymore? |
No, is still used, source connects to pan node, pan node connects to gain node, gain connects to output. |
commit:
|
you should open a PR with the same changes but for master |
I did originally base this pr against master, you switched it! |
IK, what I mean is create another PR because it's a change compatible with v4000 and v3001 |
This should be only for v3001, shouldn't merge with master |
so you mean merge this into v3001, and then do the same changes but on master? |
the error is not fault of the pr. its a pkg.pr.new issue |
You should replicate the same changes for every branch, master and v3001, then open 2 PR's |
Ok, I switched this one back to master to keep the commit history clean, will open another pr for v3001 soon |
is ready for merge? |
btw you dont really need to worry about commit history as it just gets squashed and merged into 1 commit anyway |
kaplayjs#331 / kaplayjs#335 implemented the panning but I just noticed that if the audio is paused/stopped/seeked the audio will stop going through the pan node
closes #304