Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add keyboardCode on input bindings #370

Merged
merged 1 commit into from
Aug 30, 2024
Merged

feat: add keyboardCode on input bindings #370

merged 1 commit into from
Aug 30, 2024

Conversation

lajbel
Copy link
Collaborator

@lajbel lajbel commented Aug 29, 2024

New syntax:

kaplay({
    buttons: {
        "jump": {
            "keyboardCode": ["Period", "Space"],
        }
    }
})

@lajbel
Copy link
Collaborator Author

lajbel commented Aug 29, 2024

@e1e5en-gd how it looks for you?

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 29, 2024

commit: 8fd9bcd

pnpm add https://pkg.pr.new/kaplayjs/kaplay@370

Open in Stackblitz

@e1e5en-gd
Copy link

@e1e5en-gd how it looks for you?

Good

@lajbel lajbel added the v3001&v4000 A change for stable and compatibility layer label Aug 30, 2024
@lajbel lajbel merged commit 525f557 into master Aug 30, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 30, 2024
@lajbel @web-flow
feat: add keyboardCode on input bindings (#370)
070dd4e
@github-actions github-actions bot mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflerackers mflerackers mflerackers approved these changes

Assignees
No one assigned
Labels
v3001&v4000 A change for stable and compatibility layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: When processing input, get the ID (code) of the physical button on the keyboard
3 participants
@lajbel @e1e5en-gd @mflerackers