Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Write reports one more byte written #36

Closed
dolmen opened this issue Jan 13, 2022 · 0 comments · Fixed by #38
Closed

Windows: Write reports one more byte written #36

dolmen opened this issue Jan 13, 2022 · 0 comments · Fixed by #38

Comments

@dolmen
Copy link
Contributor

dolmen commented Jan 13, 2022

Write on Windows reports one more byte written than asked for.

Internally, this is because a 0x00 byte is prepended to the data.

However:

  • this is not documented
  • this platform specific difference breaks the platform abstraction that this package is supposed to provide
dolmen added a commit to dolmen-go/legodim that referenced this issue Jan 13, 2022
@dolmen
toypad: workaround for bug in hid library
3a4ad3a 
Workaround for bug in github.com/karalabe/hid where Write report one
more byte written on Windows.
See karalabe/hid#36
This was referenced Jan 13, 2022
Open
Closed
dolmen referenced this issue in bdwyertech/hid Feb 1, 2022
@bdwyertech
make hid report prepend logic more intelligent and validate input
7df3d43
dolmen referenced this issue in bdwyertech/hid Feb 1, 2022
@bdwyertech
This seems to break Windows
6519f53
dolmen referenced this issue in sl33nyc/hid Feb 1, 2022
Remove Prepending Byte for Windows Write
230bdc8 
MSI MAG321QR's usbhid device (0x1462:0x3fa4) doesn't seem to expect
the extra byte when writing from Windows.
dolmen referenced this issue in shedimonG/hid Feb 1, 2022
@shedimonG
windows hid fix
9d8eec7
@dolmen dolmen mentioned this issue Feb 1, 2022
Closed
bearsh pushed a commit to bearsh/hid that referenced this issue Feb 1, 2022
@bdwyertech @bearsh
Do not prepend report number 0 to outgoing data on windows
9277e99 
Basically, on Windows, it's required to prepend the outgoing
data with the report id. but this is not something this shim
is supposed to do (also e.g. cython-hidapi does not do this).
furthermore, the report id could also be something != 0.

Closes: #6
See also: karalabe#36
dolmen added a commit to dolmen-go/hid that referenced this issue Feb 20, 2022
@dolmen
Fix for incorrect reported written bytes on Windows
9177eb1 
Closes karalabe#36, karalabe#16
@dolmen dolmen mentioned this issue Feb 20, 2022
Merged
pennam pushed a commit to pennam/hid that referenced this issue Jun 29, 2023
@dolmen @pennam
Fix for incorrect reported written bytes on Windows
9d82ac7 
Closes karalabe#36, karalabe#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for incorrect reported written bytes on Windows dolmen-go/hid
1 participant
@dolmen