Debug Adapter Server Handler fixes for "evaluation" and "variables" #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of current step/stack-frame snapshot.
ivangsa
added a commit
to ivangsa/karate
that referenced
this pull request
Jan 25, 2021
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets ScenarioEngine on current thread to perform evaluations
Fixes: "In debug session, all DapServerHandler.FRAMES hold the same reference to the hashmap containing de variables, which means when on debug UI you focus on a different frame you get the variables from latest frame."
Relevant Issues : 1.0 release thread #1373 (comment) Show debug variables as json (instead of strings) kirksl/karate-runner#68
Relevant PRs : (optional)
Type of change :