Move casper FFG-related config to config.py #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casper vote messages were not being caught in at least one place. Move the classification to a lower level to fix this.
This also reverts the difficulty increase to 2000 made in d133100
Moving up to Metropolis avoids error about bad opcode on REVERT. Remove a duplicate import.
|
Looks good! There were a couple chain tests which broke because of this |
|
Thanks. Will make sure to run the tests after future changes. (Although as you already know some are failing now!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9 (that PR should be merged first).
Handle casper FFG-related config the same way we do for existing config. Allows us to remove the nasty hardcoded config stuff at https://github.com/karlfloersch/pyethapp/blob/2274ab8263961cc474cc634d598ecfe7708b919d/pyethapp/eth_service.py#L178.