Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10.x breaks ng-html2js-preprocessor #146

Closed
JoshSchreuder opened this issue Mar 1, 2015 · 5 comments · Fixed by #189
Closed

0.10.x breaks ng-html2js-preprocessor #146

JoshSchreuder opened this issue Mar 1, 2015 · 5 comments · Fixed by #189

Comments

@JoshSchreuder
Copy link

Just tried updating to 0.10.0 / 0.10.1 from 0.8.3 which fail to work as I'm using ng-html2js-preprocessor.

Rolling back to 0.9.0 works correctly as per 0.8.x behaviour.

I'm not entirely sure what's going on, but I think it is something to do with this commit: @a10aaa7548267ab035f8f4689eb54b2ead9245ef

If I specify preprocessors in my grunt config:

preprocessors: {
     'modules/**/*.js': ['coverage'],
     'modules/**/*.html': ['ng-html2js']
},

The template loading in my tests fails (the preprocessor is supposed to load templates into an Angular module) and therefore a bunch of my tests break.

If I specify the above preprocessors in my Karma config, it works correctly, so I suspect there is something wrong with the above commit.

@JoshSchreuder JoshSchreuder changed the title 0.10 breaks ng-html2js-preprocessor 0.10.x breaks ng-html2js-preprocessor Mar 1, 2015
@dignifiedquire
Copy link
Member

Could you set the log level to debug and show me the output before and after please?

@fpoliquin
Copy link

Got the same problem on 0.11.1. Karma preprocessors just don't get executed. Rolling back to 0.9.0.

@mrfelton
Copy link

Same issue

@ValentinH
Copy link
Contributor

Same issue here, I'm investigating it and will try to submit a PR.

@ValentinH
Copy link
Contributor

ValentinH commented May 25, 2016

OK found it.
In my karma options, I was setting basePath: '../' but this was not used in the commit mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants