client: {useIframe: false} not taken from config file

[ghost]

If I want this option, I need to add it to grunt config itself.

[dignifiedquire]

Can you please describe in more detail what you are trying to achieve and what you tried and did not work for you?

[ghost]

I just want to use option useIframe: false. Ad "what you are trying to achieve", I hope you are not saying I should explain why I want to use that option - I have my reasons.

When it is specified in .conf file, it works fine from cli karma, but it is not honoured when used in grunt-karma. Hence, bug. As a workaround, I need to put options: {useIframe: false} into Gruntfile itself. Please, will you accept this bug (useIframe setting in .conf is not taken by grunt-karma)?

It is a bug, isn't it?

[dignifiedquire]

So you are saying you are setting the value in the your karma.conf.js file, and when running it via the cli it works fine, but when running it through grunt-karma it is not honoured? Could you share how your grunt-karma config looks like then please?

[ghost]

It is pointing to that config file, but useIframe is not honoured. Other settings are.

Friedel Ziegelmayer wrote:

So you are saying you are setting the value in the your
|karma.conf.js| file, and when running it via the cli it works fine,
but when running it through grunt-karma it is not honoured? Could you
share how your grunt-karma config looks like then please?

—
Reply to this email directly or view it on GitHub
#165 (comment).

[ghost]

The problem seems to be here:

grunt-karma/tasks/grunt-karma.js

Lines 40 to 56 in 70cdb94

	// If arguments are provided we pass them to karma
	if (args.length > 0) {
	if (!options.client) {
	options.client = {}
	}
	options.client.args = args
	}
	// Only create client info if data is provided
	if (options.client) {
	// Merge karma default options
	_.defaults(options.client, {
	args: [],
	useIframe: true,
	captureConsole: true
	})
	}

.
Since I do not run grunt, but grunt taskname, the client is set to {}, then gets the defaults applied, setting useIframe always to true, and all this before taking configfile into account.

[ghost]

No, in fact, this is the root cause:

grunt-karma/tasks/grunt-karma.js

Line 31 in 70cdb94

client: {}

.

[ghost]

Or maybe this 168f7b7. Why was useIframe: true set as default explicitly; is it needed?

[ghost]

Re: "PR please" @dignifiedquire I am not really sure how to solve this, as there is many places and they depend on each other, so you could probably know better (or some other core devs).

[gnail]

Can confirm that the default settings overrides the config file and sets UseIframe to true regardless of the config file. I ran into this while trying to get karma-electron to work which requires UseIframe to be false in order to expose the Node.js API visible from the renderer. Removing line 53 solves my problem.

[ianwremmel]

Seeing the same problem.

grunt-karma/tasks/grunt-karma.js

Line 31 in 70cdb94

client: {}

ensures that any client configuration provided in the karma config file gets discarded.

[ianwremmel]

@gnail , I'm not sure your PR entirely fixes the problem. I think the presence of options.client always means that the client provided in the config file will get discarded.

[gnail]

@ianwremmel Hmm I could've sworn that it fixed my issue but revisiting the issue says otherwise. My apologies. I think the issue lies in Karma where sub-properties are overwritten instead of merged. My PR solves half of the issue since hard-coded properties like that would take precedence no matter what, but it'd take another PR on Karma itself to solve this fully.

We could remove the empty client object too and clean up the code a bit but that'd still leave cases where passing in args or a single property overrides other properties specified in the config file.

[gnail]

I've created another PR for Karma itself. Both of these PRs work together to solve this and related issues.