-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client config in karma.conf.js is overwritten #79
Comments
I think grunt-karma should do a deep merge. Override makes sense in the case of |
This is breaking Setting |
+1. I spend lot of time figuring out why console.log stopped working a while ago. Also, the default client config: useIFrame is also overridden to undefined. I'm not sure of the impact |
Run into this today myself. I'll fix this tomorrow. |
In my karma.conf.js I have some mocha config, as described here:
https://github.com/karma-runner/karma-mocha
This line ends up overwriting that config:
https://github.com/karma-runner/grunt-karma/blob/master/tasks/grunt-karma.js#L23
Maybe karma should be merging instead of overwriting, but here's some history to that point:
karma-runner/karma#283
The text was updated successfully, but these errors were encountered: