Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Flatten files array. Closes #142 #150

Merged
merged 1 commit into from
May 28, 2015
Merged

fix: Flatten files array. Closes #142 #150

merged 1 commit into from
May 28, 2015
+1 −0

Conversation

enigmak
Copy link
Contributor

@enigmak enigmak commented May 28, 2015

fix: Flatten files array.

Closes #142

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@enigmak
Copy link
Contributor Author

enigmak commented May 28, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

dignifiedquire added a commit that referenced this pull request May 28, 2015
@dignifiedquire
Merge pull request #150 from enigmak/patch-1
d7e70c1 
fix: Flatten files array.  Closes #142
@dignifiedquire dignifiedquire merged commit d7e70c1 into karma-runner:master May 28, 2015
@dignifiedquire
Copy link
Member

Thanks a lot

Krinkle added a commit that referenced this pull request Aug 27, 2018
@Krinkle
chore: add test for flattened 'files' option and clean up code
50c29b8 
- This feature was added in pull #150 without a test.
  It now has a test.

- The code was applying the flatten operation to all input,
  but should really only be applied to `options.files`, not to
  this.files from Grunt, which is already processed.

- The code was checking `data.files` but using `this.files`.
  This is working correctly, but looks confusing to a reader.
  `data.files` is the raw input, and `this.files` is the version
  of that input after processing by Grunt.
  To improve readability, use that same reference for the check
  as well. In order to keep behaviour identical, use the array's
  length property to determine whether it was set. The files
  array is always available from Grunt, and can be safely accessed
  without additional check. This is covered by the karma:config
  test case, which specifies neither options.files nor data.files.

Ref #150.
Closes #236.
@Krinkle Krinkle mentioned this pull request Aug 27, 2018
Merged
Krinkle added a commit that referenced this pull request Aug 27, 2018
@Krinkle
chore: add test for flattened 'files' option and clean up code
bd1cc47 
- This feature was added in pull #150 without a test.
  It now has a test.

- The code was applying the flatten operation to all input,
  but should really only be applied to `options.files`, not to
  this.files from Grunt, which is already processed.

- The code was checking `data.files` but using `this.files`.
  This is working correctly, but looks confusing to a reader.
  `data.files` is the raw input, and `this.files` is the version
  of that input after processing by Grunt.
  To improve readability, use that same reference for the check
  as well. In order to keep behaviour identical, use the array's
  length property to determine whether it was set. The files
  array is always available from Grunt, and can be safely accessed
  without additional check. This is covered by the karma:config
  test case, which specifies neither options.files nor data.files.

Ref #150.
Closes #236.
Krinkle added a commit that referenced this pull request Aug 28, 2018
@Krinkle
chore: add test for flattened 'files' option and clean up code (#262)
0174ca8 
- This feature was added in pull #150 without a test.
  It now has a test.

- The code was applying the flatten operation to all input,
  but should really only be applied to `options.files`, not to
  this.files from Grunt, which is already processed.

- The code was checking `data.files` but using `this.files`.
  This is working correctly, but looks confusing to a reader.
  `data.files` is the raw input, and `this.files` is the version
  of that input after processing by Grunt.
  To improve readability, use that same reference for the check
  as well. In order to keep behaviour identical, use the array's
  length property to determine whether it was set. The files
  array is always available from Grunt, and can be safely accessed
  without additional check. This is covered by the karma:config
  test case, which specifies neither options.files nor data.files.

Ref #150.
Closes #236.
@Krinkle Krinkle mentioned this pull request Nov 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arguments to path.resolve must be strings
3 participants
@enigmak @googlebot @dignifiedquire