fix(adapter): do not emit debug url unless in a browser #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
reviewed
Feb 9, 2020
src/adapter.js
Outdated
| @@ -247,8 +247,10 @@ function KarmaReporter (tc, jasmineEnv) { | |||
| result.log.push(formatFailedStep(steps[i])) | |||
| } | |||
|
|
|||
| // Report the name of fhe failing spec so the reporter can emit a debug url. | |||
| result.debug_url = debugUrl(specResult.fullName) | |||
| if (window && window.location && window.location.origin) { | |||
There was a problem hiding this comment.
Are we assuming that this code will run in Node?
According to #262 that doesn't seem like the case.
window is still defined, but window.location is not, because the error message was
Cannot read property 'origin' of undefined
when trying to access window.location.origin
I'm asking because the check for 'window' done this way will actually throw a ReferenceError in Node
There was a problem hiding this comment.
Of course I don't know how this error can happen. But you are completely correct, so I used typeof.
Surprise: someone uses karma-jasmine with native=script. Fixes karma-runner#262
johnjbarton
force-pushed
the
native-script
branch
from
86251a1 to
27f5dc7
Compare
kyliau
approved these changes
Feb 10, 2020
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprise: someone uses karma-jasmine with native=script.
Fixes #262