fix: Add back outputFile config
#59
Merged
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
fix-output-file
branch
from
fadbe8b
to
b4583b5
Compare
|
Why does this automatically nest inside a |
Because that was the previous behaviour, which I'm trying to restore |
erkobridee
added a commit
to erkobridee/jenkins-ci-and-karma-junit-reporter
that referenced
this pull request
Sep 8, 2015
- karma-junit-reporter #59 karma-runner/karma-junit-reporter#59 - related to #58 karma-runner/karma-junit-reporter#58
|
If this restores old behavior, why is it not merged? You broke backwards compatibility in a patch release. Please revert and bump minor (as you're still on 0.x.x (why isn't Karma and it's plugins on 1.x.x btw?)) with this new behavior if it's still wanted. For us nesting is fine, as we do Fix for now is of course just to revert to |
|
@dignifiedquire bump. |
|
Merging, to restore old behaviour. |
dignifiedquire
added a commit
that referenced
this pull request
Sep 27, 2015
fix: Add back `outputFile` config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58