Skip to content
This repository has been archived by the owner on Dec 28, 2023. It is now read-only.

remove peer deps & update installation instructions; closes #114 #116

Merged
merged 1 commit into from
Oct 31, 2016

Conversation

boneskull
Copy link
Contributor

  • this is a breaking change and should probably be released as v2.0.0

…ner#114

- this is a breaking change and should probably be released as v2.0.0
@dignifiedquire
Copy link
Member

Thank you but I don't see a good reason to remove the peerDependency. We use it in all other plugins as well.

@boneskull
Copy link
Contributor Author

Discussion in #114. Just because it's used elsewhere doesn't mean it should be. If anything, karma should be the peer dep; not mocha.

@boneskull boneskull mentioned this pull request Oct 31, 2016
@maksimr
Copy link
Contributor

maksimr commented Oct 31, 2016

@dignifiedquire this comment was good reason to remove peer dependency for me.

@dignifiedquire
Copy link
Member

alright, lets merge this :)

@dignifiedquire dignifiedquire merged commit 0bbf932 into karma-runner:master Oct 31, 2016
@maksimr maksimr mentioned this pull request Nov 7, 2016
@maksimr
Copy link
Contributor

maksimr commented Nov 7, 2016

@boneskull do you still need this tweaked version of karma-mocha?

@boneskull
Copy link
Contributor Author

@maksimr until this change is published, yes

@dignifiedquire
Copy link
Member

published in 1.3.0

@boneskull
Copy link
Contributor Author

is this not breaking?

@dignifiedquire
Copy link
Member

is this not breaking?

I didn't think so, if your code worked before, it will still work. People had to install peerDependencies by themselves since npm@3 anyway.

@boneskull boneskull deleted the issue/114 branch November 16, 2016 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants