Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix TravisCI build #46

Closed
wants to merge 1 commit into from
Closed

chore: fix TravisCI build #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
language: node_js
node_js:
- 0.8
- "0.8"
- "0.10"

before_install:
- '[ "${TRAVIS_NODE_VERSION}" != "0.8" ] || npm install -g npm@1.4.28'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is unnecessary! Otherwise LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aymericbeaumet Ha! I must say that I've copied this line as a monkey, without fully understanding it :-/ Shame on me. The thing is that without this line it wasn't working:
https://travis-ci.org/karma-runner/karma-ng-html2js-preprocessor/jobs/37902879

Do you know what this line supposed to do / why it is here (Pawel looks up bash syntax feeling ashamed...).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It installs a specific npm version in the case node 0.8 is detected. It's weird because I thought updating npm to the latest version would suffice.

It seems npm 1.4.28 is the latest version supported by node. So let's just leave it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guys this line fixes problem with updating npm on node@0.8 :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maksimr thnx, although I still don't understand why do we need to call both npm install -g npm@1.4.28 and npm install -g npm@latest on node 0.8. Shouldn't this line
'[ "${TRAVIS_NODE_VERSION}" != "0.8" ] || npm install -g npm@1.4.28'
be enough?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkozlowski-opensource seems npm install -g npm@1.4.28 should be enough to fix all problems associated with npm and node@0.8.
Because we ran npm install -g npm for the same reasons(fix problem with node and travis).

Also latest version of npm is 2.* that may not solve the problem with node@0.8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just stick with npm install -g npm@1.4.28 for now.


before_script:
- npm install -g grunt-cli
Expand Down