feat(server): improve public api #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a slew of new api possibilities to the server. All main events from the `globalEmitter` are now emitted on the `server` instances and publicly available. For a list of available events see the docs file. BREAKING CHANGE: The public api interface has changed to a constructor form. To upgrade change ```javascript var server = require(‘karma’).server server.start(config, done) ``` to ```javascript var Server = require(‘karma’).Server var server = new Server(config, done) server.start() ``` Closes karma-runner#1037, karma-runner#1482, karma-runner#1467
This was referenced Jul 8, 2015
|
@zzo @maksimr @pkozlowski-opensource if you have some time, please take a look and let me know what you thinkg |
|
like it. Now would be the time to get in breaking changes. |
dignifiedquire
added a commit
that referenced
this pull request
Jul 13, 2015
feat(server): improve public api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a slew of new api possibilities to the server. All main
events
from the
globalEmitterare now emitted on theserverinstances andpublicly available.
For a list of available events see the docs file.
BREAKING CHANGE:
The public api interface has changed to a constructor form. To upgrade
change
to
Closes #1037, #1482, #1467